Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename examples to _examples #218

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Rename examples to _examples #218

merged 2 commits into from
Feb 10, 2020

Conversation

axw
Copy link
Contributor

@axw axw commented Feb 10, 2020

Rename the examples directory so that the examples' dependencies don't leak into the main module.

Rename the examples so that their dependencies
don't leak into the main module.
@mxygem
Copy link
Member

mxygem commented Feb 10, 2020

Hi and welcome @axw! Thanks for the help with this. Would you mind updating the changelog and adding your changes to the unreleased section please?

@axw
Copy link
Contributor Author

axw commented Feb 10, 2020

@jaysonesmith no problem, updated.

@mxygem
Copy link
Member

mxygem commented Feb 10, 2020

Thank you! That's helped me realize we're using the wrong link format and likely my fault. :p

@mxygem mxygem merged commit 58038ce into cucumber:master Feb 10, 2020
@aslakhellesoy
Copy link
Contributor

Hi @axw,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@axw axw deleted the rename-examples branch February 10, 2020 06:06
@mxygem
Copy link
Member

mxygem commented Feb 10, 2020

Also, @axw : In the Changelog, the brackets around usernames is used to help link to folk's GH pages, but needs a corresponding link to do so. If you look at the end of the changelog file, you'll see what I mean. I'm working on an update to the file now that'll include you, so don't worry about doing it. :)

@axw
Copy link
Contributor Author

axw commented Feb 10, 2020

@jaysonesmith ugh, sorry - I should have checked the output. Thank you.

@mxygem
Copy link
Member

mxygem commented Feb 10, 2020

@axw No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants